RIP build now makes a temp file or folder (I think called $) in the working directory where linuxcnc 2.10pre is invoked from the command line

[rodw-au]

This seems to be a new issue in the last week or so. If you run the rip-environment script and then move to a system folder (eg /etc),
and run a linuxcnc sim, Linuxcnc crashes becasue it does not have permissions to create the temporary folder.

From my memory where am building and testing linuxcnc at least once a week, this is new behaviour.

If you run Linuxcnc from within your home folder, the error does not occur. Presumably because you have write access.

[BsAtHome]

Would this be related to #3908 and subsequent revert in #3918?

[NTULINUX]

Doesn't look like it. Before and after the revert I had this same issue. Happens on system installs too, not just rip.

[BsAtHome]

Since when does this then fail?

[NTULINUX]

It doesn't fail, it just puts all the configs in ${HOME}/$ so it's ugly xD I can bisect some other time, late here.

[BsAtHome]

That somehow looks like a failed expansion of a shell variable.

[NTULINUX]

Probably xD

[rodw-au]

I had a bit more of a play on a clean QEMU install from the home directory where it makes the ~/$ folder. I was hoping there was a environment variable I could set but could find nothing in the docs. I did check that $(HOME)/linuxcnc/config existed before my testing. Being able to set the BASE_DIR would be useful.

I will check from a read only system folder in the morning to confirm what I said in my first post..

[grandixximo]

@BsAtHome This could be related to #3739

[grandixximo]

@BsAtHome

I think the issue is in tcl/linuxcnc.tcl.in after substitution from configure.ac:

foreach _dir [split {@LINUXCNC_CONFIG_PATH_TCL@} :] {
    lappend CONFIG_DIR [file normalize $_dir]
}

LINUXCNC_CONFIG_PATH_TCL is "$::env(HOME)/linuxcnc/configs:...". Inside {} the $::env(HOME) doesn't get expanded, and split on : then chops the literal :: in two.

So the first element ends up as just $, which file normalize resolves to [pwd]/$. That becomes USER_CONFIG_DIR, and pickconfig later does file mkdir on it.

Introduced in 6f0bf8b when ~ was swapped for $::env(HOME).

[BsAtHome]

That could very well be the problem. So, that substitute needs an evil eval or, better, simply evaluated and expanded before the split.

[grandixximo]

I think so. Either dropping the {} to "..." (Tcl double-quotes allow $var substitution)

--- a/tcl/linuxcnc.tcl.in
+++ b/tcl/linuxcnc.tcl.in
@@ -25,7 +25,7 @@ namespace eval linuxcnc {
     variable TCL_SCRIPT_DIR @EMC2_TCL_DIR@/scripts
     variable HELP_DIR @EMC2_HELP_DIR@
     variable RTLIB_DIR @EMC2_RTLIB_DIR@
-    variable CONFIG_PATH {@LINUXCNC_CONFIG_PATH_TCL@}
+    variable CONFIG_PATH "@LINUXCNC_CONFIG_PATH_TCL@"
     variable NCFILES_DIR @EMC2_NCFILES_DIR@
     variable LANG_DIR @EMC2_LANG_DIR@
     variable IMAGEDIR @EMC2_IMAGE_DIR@
@@ -33,7 +33,7 @@ namespace eval linuxcnc {
     variable RTS @RTS@
     variable CONFIG_DIR {}
     variable _dir
-    foreach _dir  [split {@LINUXCNC_CONFIG_PATH_TCL@} :] {
+    foreach _dir  [split "@LINUXCNC_CONFIG_PATH_TCL@" :] {
 	lappend CONFIG_DIR [file normalize $_dir]
     }
     unset _dir

or running subst on it before the split would expand $::env(HOME) to /home/username, which cannot have colons in it, so the split-on-: then works correctly. No actual eval needed.

[rodw-au]

Forgot to mention that this is also happening if you build and install the 2.10 Deb files. I was going to test but I remembered I have already been bitten with this bug.

[Sigma1912]

possibly related #3818

[BsAtHome]

Could anyone test @grandixximo suggesting from #3924 (comment)?

[grandixximo]

@rodw-au can you change those lines and test? does that fix it?