Skip to content

bug(gremlin): incorrect gcode checking due to wrong initialization #4121

@Sigma1912

Description

@Sigma1912

As reported on the forum:
https://forum.linuxcnc.org/38-general-linuxcnc-questions/58828-potential-bug-in-version-2-9-8#346874

This is related to this earlier bug fix: f6b704e
which has already been trying to address issues with incorrect gcode preview when loading gcode that does not contain complete preambles.

Cause:
While the bugfix above works for the actual tool path preview it does not work for the error checking done in the interpreter run on load as the interpreter uses it's internal defaults.

Fix:
Going back to initializing the interpreter with the RS274NGC_STARTUP_CODE is not the right fix as it will reintroduce issue #2753. Instead the interpreter run on load should be initialized with the currently active modal gcodes. This should also address other potential bugs when loading gcode with incomplete preambles.

Affects:
Any Gui using 'gremlin.py' for gcode preview. (eg gmoccapy)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions