motmod refactoring: Remove joint and axis internal data from shared mem#1613
Merged
dngarrett merged 2 commits intoLinuxCNC:masterfrom Feb 17, 2022
Merged
motmod refactoring: Remove joint and axis internal data from shared mem#1613dngarrett merged 2 commits intoLinuxCNC:masterfrom
dngarrett merged 2 commits intoLinuxCNC:masterfrom
Conversation
This patch takes a first step in reducing the scope of internal data of motmod by making joints' and axes' internal data inaccessible from "the rest of the world". Rationale: Reducing the scope of data makes the code easier to maintain and extend. (Specifically, this is part of preparation for adding jerk limited jog planning in the future.)
Contributor
Author
|
I should add that this PR has been test built on uspace and rtai (realtime-4.19.195-rtai-amd64), and passes runtests (tested on uspace). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch takes a first step in reducing the scope of internal data of motmod by making joints' and axes' internal data inaccessible from "the rest of the world".
Rationale: Reducing the scope of data makes the code easier to maintain and extend. (Specifically, this is part of preparation for adding jerk limited jog planning in the future.)