Gmoccapy: fix button state when enter setting page from MDI or Auto Mode 2.8#1706
Merged
rene-dev merged 1 commit intoLinuxCNC:2.8from Aug 8, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like mentioned in #1548 (comment) the MDI and Auto Mode buttons are only disabled when entering the settings page from manual mode. When entering the setup page from the other modes, MDI and Auto mode is clickable.
I am not 100% sure if this is intended, but I think so. Otherwise the else branch in
on_tbtn_setup_toggled()wouldn't make sense if it is allowed to leave the settings page by clicking on a mode button.