Fix soft limit calculation when using G43.1#1783
Merged
c-morley merged 1 commit intoLinuxCNC:masterfrom Jul 2, 2022
Merged
Conversation
As discussed in this forum thread: https://forum.linuxcnc.org/20-g-code/44244-g43-1-dynamic-tool-length-measurement-program-exceeds-machine-maximum-on-axis?start=10#227198 When using G43.1 Tool Length Offset, Axis will wrongly display a warning about exceeding the soft limits. This PR adds the tool offset to the limits calculation so this warning wont be displayed anymore if not needed (It still will if it actually exceeds the limit).
Collaborator
|
Thank you |
Collaborator
|
Should this be carried back to 2.8? |
andypugh
pushed a commit
that referenced
this pull request
Oct 2, 2023
This reverts #1783 and attempts to fix #2646 gcodemodule.cc accurately computes the joint limits, including tool offsets. There is no need to add the last tool loaded on after the fact before testing However, it only computes the extents at G-code load time And the limits check is done when the Axis run button is pressed If the tool lengths have changed (MDI, tool length probe...) then at the point that the run button is pressed the g-code extents are out-of-date This patch adds a new "re-check" button to the error dialog which reloads the G-code than checks the limits again. See issue 2646 for more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in this forum thread:
https://forum.linuxcnc.org/20-g-code/44244-g43-1-dynamic-tool-length-measurement-program-exceeds-machine-maximum-on-axis?start=10#227198
When using G43.1 Tool Length Offset, Axis will wrongly display a warning about exceeding the soft limits.
This PR adds the tool offset to the limits calculation so this warning wont be displayed anymore if not needed (It still will if it actually exceeds the limit).