Made tests/motion/g0 more robust and got rid of race condition#1859
Merged
c-morley merged 1 commit intoLinuxCNC:masterfrom Jul 28, 2022
Merged
Made tests/motion/g0 more robust and got rid of race condition#1859c-morley merged 1 commit intoLinuxCNC:masterfrom
c-morley merged 1 commit intoLinuxCNC:masterfrom
Conversation
petterreinholdtsen
force-pushed
the
test-g0-robustness
branch
2 times, most recently
from
d5418f7 to
de50593
Compare
Adjusted test.sh to make sure halsampler run until all instructions are sent via port 5007 to linuxcncrsh. Now wait for explicite process IDs of halsampler and linuxcnc to make sure neither terminated before test is over. Added more checks in checkresults, and made sure it give more sensible error messages if no acceleration is detected (instead of raising out of bound exceptions. Replaced random sleep periods with code to wait for pins to signal startup, homing and move is completed.
petterreinholdtsen
force-pushed
the
test-g0-robustness
branch
from
de50593 to
2cdad46
Compare
petterreinholdtsen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted test.sh to make sure halsampler run until all instructions are sent
via port 5007 to linuxcncrsh. Now wait for explicite process IDs of halsampler
and linuxcnc to make sure neither terminated before test is over. Added more
checks in checkresults, and made sure it give more sensible error messages
if no acceleration is detected (instead of raising out of bound exceptions.
Replaced random sleep periods with code to wait for pins to signal startup,
homing and move is completed.