Skip to content

Gmoccapy - czech translate#1874

Merged
hansu merged 4 commits intoLinuxCNC:2.8from
zz912:patch-7
Sep 16, 2022
Merged

Gmoccapy - czech translate#1874
hansu merged 4 commits intoLinuxCNC:2.8from
zz912:patch-7

Conversation

@zz912
Copy link
Copy Markdown
Contributor

@zz912 zz912 commented Jul 27, 2022

I made a translation for Gmoccapy. This is not a literal translation, but a translation that is user friendly. Contains many untranslated phrases. I am of the opinion that the original text is better than a bad translation.

I made a translation for Gmoccapy. This is not a literal translation, but a translation that is user friendly. Contains many untranslated phrases.  I am of the opinion that the original text is better than a bad translation.
@hansu
Copy link
Copy Markdown
Member

hansu commented Jul 27, 2022

I am of the opinion that the original text is better than a bad translation.

I totally agree.

@petterreinholdtsen, @silopolis Is the following the correct order for adding this new language to Weblate?

  1. Accept this PR
  2. Merge 2.8 to master
  3. Create a new language on Weblate

Or should the new language created first on Weblate?

@petterreinholdtsen
Copy link
Copy Markdown
Collaborator

petterreinholdtsen commented Jul 27, 2022 via email

@zz912
Copy link
Copy Markdown
Contributor Author

zz912 commented Jul 27, 2022

If this cs.po file is also added to the main branch, will it be possible to change it directly? I don't know how Weblate works, I'm fine with Poedit, but I don't want to create any problems in the future if I change the cs.po file directly without solving anything with weblate.

@hansu
Copy link
Copy Markdown
Member

hansu commented Jul 27, 2022

Thanks Petter!

If this cs.po file is also added to the main branch, will it be possible to change it directly? I don't know how Weblate works, I'm fine with Poedit, but I don't want to create any problems in the future if I change the cs.po file directly without solving anything with weblate.

If you plan to extend/improve this po file for 2.8 in the next time, we should better postpone this PR.
Once it is in master (and likely in Weblate), direct changes to this file would cause merge conflicts.

When it's in Weblate, it should be only edited there. And getting these changes back to 2.8 would probably cause conflicts as well.

@petterreinholdtsen
Copy link
Copy Markdown
Collaborator

petterreinholdtsen commented Jul 27, 2022 via email

@zz912
Copy link
Copy Markdown
Contributor Author

zz912 commented Jul 27, 2022

I studied many videos in Youtube aboat git an Github and I am not sure about right working.
I understood that cs.po in 2.8 can be modified directly and then I should make Pull request.
I understood that cs.po in 2.9 must be modified by weblate.

I dont understand:

And getting these changes back to 2.8 would probably cause conflicts as well.

Exist some automatic proces for merging from master branche to 2.8 branche?
Or did you write this sentence just in case someone thought of it?

I'm not against weblate, but my main goal was to translate for version 2.8

@hansu
Copy link
Copy Markdown
Member

hansu commented Jul 27, 2022

We are using the merge upward workflow, that means 2.8 is merged more or less regularly into master. So the cs.po will go to master at some point. And then be modified by Weblate. And if you then make changes in 2.8 it would cause merge conflicts on the next merge from 2.8 to master.

Exist some automatic proces for merging from master branche to 2.8 branche?

No.

I'm not against weblate, but my main goal was to translate for version 2.8

Providing an initial version for 2.8 is no problem. Only changes to this afterwards would cause conflicts.
So if you think your cs.po is complete, we can go for that.

@zz912
Copy link
Copy Markdown
Contributor Author

zz912 commented Jul 27, 2022

Is there any way to split cs.po for version 2.8 and for master version?

@petterreinholdtsen
Copy link
Copy Markdown
Collaborator

petterreinholdtsen commented Jul 27, 2022 via email

@hansu
Copy link
Copy Markdown
Member

hansu commented Jul 27, 2022

The only possibility I see is to commit the changes of cs.po to 2.8 and then merge 2.8 immediately to master and select the changes from master on conflicts, so that the file doesn't change on master. But this is a bit risky if someone else does the merge and don't know about this.

@zz912
Copy link
Copy Markdown
Contributor Author

zz912 commented Jul 27, 2022

The only possibility I see is to commit the changes of cs.po to 2.8 and then merge 2.8 immediately to master and select the changes from master on conflicts, so that the file doesn't change on master. But this is a bit risky if someone else does the merge and don't know about this.

I don't want to do anything risky.

I discussed this problem with a Czech-speaking programmer over the phone. The solution could be something like this:

Let's do everything as HansU suggested first. As soon as I make another Pull request for cs.po for the 2.8 branch, I will put in the message:

Warning: Do not merge with master branch. There may be a conflict with weblate.

Do you think this is a clean solution?

Currently, HansU has done some bug fixing that affects the cs.po file. Therefore, I would like to ask you to hold this Pull Request until I process all the information that HansU sent me on the forum.

@hansu
Copy link
Copy Markdown
Member

hansu commented Jul 27, 2022

If you want to hold back this PR, you can click "Convert to draft" in the upper right corner in the "Reviewers" section, then everybody knows that there is work in progress.

Let's do everything as HansU suggested first. As soon as I make another Pull request for cs.po for the 2.8 branch, I will put in the message:

Warning: Do not merge with master branch. There may be a conflict with weblate.

Better: "Warning: After merging this PR, please merge the 2.8 branch immediately into master and make sure the changes from this file don't go into master"
But I wouldn't call it "clean" 😉

Because with your message you cannot prevent that the merge will be done at some time later.

@zz912 zz912 marked this pull request as draft July 27, 2022 19:13
@smoe
Copy link
Copy Markdown
Collaborator

smoe commented Aug 1, 2022

Hm. First off: I am very happy for CZ translations - welcome!!! Just, how to get there. I am somewhat confident that all translation work should be done via weblate. And since these strings change in the English all the time, we would have conflicts between 2.8 and 2.9 all the time. Since 2.9 should surface somewhen in the not too far future, I suggest to not touch 2.8 for CZ at all and focus with all your might on 2.9 and getting that out of the door.

@zz912
Copy link
Copy Markdown
Contributor Author

zz912 commented Aug 1, 2022

I would like to finish the Czech language for 2.8. I devoted a lot of time to it. HansU helped me a lot to fix the errors that were in 2.8 and were related to the translation. I hope there will be a version 2.8.3. Currently the translation is stuck on the problem of poorly generated pot files in version 2.8.
https://forum.linuxcnc.org/gmoccapy/46275-translate-offsetpage-glade-h-dont-work?start=20#248521

It is fixed in version 2.9, but if we keep telling ourselves that it is not worth maintaining a stable version of LCNC, then a good stable version will never exist.

@zz912 zz912 marked this pull request as ready for review September 13, 2022 10:14
@zz912
Copy link
Copy Markdown
Contributor Author

zz912 commented Sep 13, 2022

Hello,

I made last change for translate Gmoccapy for LCNC 2.8. I would like ask you only for merge to Branche 2.8 . I am not sure If I will have enough time for version 2.9 with Weblate. So I don't want to oblige anyone else.

I made query in forum https://forum.linuxcnc.org/37-international-linuxcnc-users/46703-split-po-files-weblate-manual
about working with Webalte without answer.

@hansu
Copy link
Copy Markdown
Member

hansu commented Sep 13, 2022

Nice, I'll merge it later.
Then I will merge 2.8 up to master, and the language will show up on Weblate. Then only the strings have to be checked/translated which changed from 2.8 to 2.9 😉

I made query in forum https://forum.linuxcnc.org/37-international-linuxcnc-users/46703-split-po-files-weblate-manual
about working with Weblate without answer.

I answered 😉

@zz912 zz912 marked this pull request as draft September 13, 2022 10:37
@zz912 zz912 marked this pull request as ready for review September 13, 2022 10:42
@hansu
Copy link
Copy Markdown
Member

hansu commented Sep 15, 2022

@zz912 zz912 marked this pull request as draft 2 days ago
@zz912 zz912 marked this pull request as ready for review 2 days ago

So ready for merge?

@zz912
Copy link
Copy Markdown
Contributor Author

zz912 commented Sep 15, 2022

Yes, this was my mistake. I uploaded two same files. Now it is correct.

@hansu hansu merged commit c714a40 into LinuxCNC:2.8 Sep 16, 2022
@hansu
Copy link
Copy Markdown
Member

hansu commented Sep 16, 2022

The Czech translation is now on Weblate 🎉
Still at 85%, so 15% of the strings have changed (if it was at 100% before)

https://hosted.weblate.org/projects/linuxcnc/gmocappy/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants