Copyright typo's and minor adjustment#1882
Merged
SebKuzminsky merged 3 commits intoLinuxCNC:masterfrom Jul 29, 2022
Merged
Conversation
GPL-3+ section wrongly mentions version 2
Collaborator
|
Note, your LGPL change do not match the header in src/hal/hal_lib.c. |
Contributor
Author
|
I believe this is something that should be addressed in Would have been easier if we had used SPDX IDs. Edit: This also applies to |
The old license was called 'GNU Library General Public License', not 'GNU Lesser General Public License' as in 'Lesser' -> 'Library'. There was also a number mismatch on the last line, referring to version 2.1.
The files was copyrighted LGPL-2, while the copyright notice mentioned LGPL-2.1. I'm assuming the mistake was in the copyright notice, not the copyright itself.
havardAasen
force-pushed
the
copyright-typo
branch
from
8c1df81 to
5436b1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles some minor issues in GPL-3+ and LGPL-2 section