Phillc54/pncconf#1888
Merged
phillc54 merged 1 commit intoLinuxCNC:masterfrom Aug 1, 2022
Merged
Conversation
Collaborator
|
It is unclear from your commit message why this feature is needed, ie what problem it solve. Some of the strings that seem to be user facing seem to lack the _() marker to ensure the strings are translatable. I failed to understand why passing some command line info on to the probe code is a hack, perhaps the 'hack' message could elaborate a bit on this? |
c-morley
approved these changes
Jul 31, 2022
Collaborator
c-morley
left a comment
c-morley
left a comment
There was a problem hiding this comment.
Looks good. As noted, for translation the translatable text messages should have _() around them.
Collaborator
|
I believe the 'hack' is because it's inferred data rather then directly stated. ie PCI is a final option only because it has no other way to set it - process of elimination. |
fix 7i96s stepgen polarity add a 7i98 firmware add connector names for 5i25, 7i76e, 7i93, and 7i98
phillc54
force-pushed
the
phillc54/pncconf
branch
from
7941c2b to
5161841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PnCconf:
Add some error messages.
Fix 7i96s stepgen polarity.
Add a 7i98 firmware.
Add some connector names.