Skip to content

docs: plasma: Weblate-ready tables and improved optics (docs_misc_9)#2056

Merged
hansu merged 1 commit intoLinuxCNC:masterfrom
smoe:docs_misc_9
Oct 15, 2022
Merged

docs: plasma: Weblate-ready tables and improved optics (docs_misc_9)#2056
hansu merged 1 commit intoLinuxCNC:masterfrom
smoe:docs_misc_9

Conversation

@smoe
Copy link
Copy Markdown
Collaborator

@smoe smoe commented Sep 21, 2022

The changes to the tables are important. The rest is just optics.

@silopolis
Copy link
Copy Markdown
Contributor

silopolis commented Sep 22, 2022 via email

@hansu
Copy link
Copy Markdown
Member

hansu commented Sep 22, 2022

Speaking of optics, those special chars really tend to make my eyes bleed 😫

I suggested to simply insert the Unicode characters...

@silopolis
Copy link
Copy Markdown
Contributor

silopolis commented Sep 22, 2022 via email

@smoe
Copy link
Copy Markdown
Collaborator Author

smoe commented Sep 22, 2022

I suggest not to bother about anything that can be addressed with a recursive sed -i . And while I do not know how to key those in, we will figure this out, eventually. The challenge for now it to decide where to place those characters and how to know that such a special character is already in place. So, for the moment, I think thos   and &#whatever: are doing a very good job.

@hansu hansu changed the title docs: plasma: Weblate-ready tables and improved optics docs: plasma: Weblate-ready tables and improved optics (docs_misc_9) Sep 23, 2022
@hansu
Copy link
Copy Markdown
Member

hansu commented Sep 23, 2022

@smoe: It's sometimes a bit difficult to find the corresponding PR when looking at your branches. It would be nice if you could add a reference like I did e.g. for the next ones. Thanks.

@silopolis
Copy link
Copy Markdown
Contributor

silopolis commented Sep 23, 2022 via email

Comment thread docs/src/plasma/qtplasmac.adoc Outdated
Comment thread docs/src/plasma/qtplasmac.adoc Outdated
Copy link
Copy Markdown
Collaborator Author

@smoe smoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased + squashed. Manually went through it - looked fine to me.

@smoe
Copy link
Copy Markdown
Collaborator Author

smoe commented Oct 5, 2022

We should have a docs-wide check on how the Mesa cards are spelled (all in caps on the Mesa website) and volts/ampere/watt - should all start with a capital. I caught most of them by now, I think, but these small ones keep escaping me.

Comment thread docs/src/plasma/qtplasmac.adoc Outdated
Comment thread docs/src/hal/tools.adoc
Comment thread docs/src/hal/tools.adoc Outdated
@silopolis
Copy link
Copy Markdown
Contributor

silopolis commented Oct 5, 2022

We should have a docs-wide check on how the Mesa cards are spelled (all in caps on the Mesa website) and volts/ampere/watt - should all start with a capital. I caught most of them by now, I think, but these small ones keep escaping me.

Absolutely !
I'd like us to explore Vale for this. See:

Comment thread docs/src/drivers/hostmot2.adoc Outdated
@silopolis
Copy link
Copy Markdown
Contributor

silopolis commented Oct 12, 2022 via email

The long paragraph are more laborious to work with in git,
shortening emerged via sentence-wise conflict checks during rebase.

Co-authored-by: Jérémie Tarot <silopolis@gmail.com>

docs: Smallish changes while chasing build error

docs/qtplasma: eliminated erroneous merge redundancy

Fixes and semantic line breaks.
@smoe
Copy link
Copy Markdown
Collaborator Author

smoe commented Oct 15, 2022

Rebase and squash to master. Think to have done as requested.

@hansu hansu merged commit a00af64 into LinuxCNC:master Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants