Added rtapi_ioperm() declaration for hal_speaker#2164
Merged
andypugh merged 2 commits intoLinuxCNC:2.9from Dec 7, 2022
Merged
Conversation
Collaborator
Author
|
Note, I do not know if this is a good idea, as I do not understand the scope and purpose of the rtapi set of methods. |
Collaborator
|
The Realtime API (RTAPI) is meant to be an abstraction layer that makes it so all our realtime code can run on all the available realtime kernels. Functionality like starting threads, allocating shared memory segments, or accessing I/O ports is done differently on different realtime kernels and platforms, but RTAPI provides an API that hides all those differences. So yes, i think this new function belongs in RTAPI. Please also add it to the rtapi_io manpage. |
This fixes the following compiler warning:
hal/drivers/hal_speaker.c: In function ‘rtapi_app_main’:
hal/drivers/hal_speaker.c:164:9: warning: implicit declaration of function ‘ioperm’ [-Wimplicit-function-declaration]
164 | if (ioperm(SPEAKER_PORT, 1, 1) < 0) {
| ^~~~~~
ba50b24 to
88874bd
Compare
Collaborator
Author
|
[Sebastian Kuzminsky]
Please also add it to the rtapi_io manpage.
OK, man page updated.
…--
Happy hacking
Petter Reinholdtsen
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following compiler warning:
hal/drivers/hal_speaker.c: In function ‘rtapi_app_main’: hal/drivers/hal_speaker.c:164:9: warning: implicit declaration of function ‘ioperm’ [-Wimplicit-function-declaration]
164 | if (ioperm(SPEAKER_PORT, 1, 1) < 0) {
| ^~~~~~