Merged
Conversation
JT reports on IRC that `halcompile --install` installs uspace realtime comps (which are .so files) with execute permissions enabled, which is wrong. This commit modifies some existing halcompile tests to verify that `halcompile --install` makes userspace (non-rt) comps executable, and rt comps (at least in uspace) non-executable. The second part of that currently fails, fixed in the following commit. (Note that our debs correctly have no execute bits set for the .so realtime comps.)
Not sure why gcc sets the execute bits on .so output files, but this sledge hammer fixes the problem.
Collaborator
|
The best-possible fix would probably be to find out why the exact reason why that executable flag was set. I only found linuxcnc/src/hal/utils/halcompile.g Line 1233 in e929156 Either way, I approve this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the permissions of
.souspace realtime components built by halcompile. For some reason they come out of gcc executable, which doesn't hurt anything but still isn't right. This just chmods them after building to turn off thexbit.Also adds checks to existing halcompile tests that verify that "userspace" (non-realtime) components are executable (they are) and realtime components are not executable (they aren't, after this PR).