What popped up while reviewing/adapting translations (smoe docs29_misc_16)#2357
What popped up while reviewing/adapting translations (smoe docs29_misc_16)#2357hansu merged 10 commits intoLinuxCNC:2.9from
Conversation
smoe
force-pushed
the
docs29_misc_16
branch
2 times, most recently
from
6f4a2fa to
1291bc8
Compare
|
@c-morley maybe it's good if you review the qtvcp-part and other parts you are maintaining? |
|
|
||
| `"a message text"`:: | ||
| Returning a string from a handler means 'this is an error message, abort the program'. Works like `(abort,` __<msg>__ `)`. | ||
| `"a message text"`:: Returning a string from a handler means 'this is an error message, abort the program'. Works like `(abort,` __<msg>__ `)`. |
There was a problem hiding this comment.
"a message text" or `a message text` but both seems a bit duplicated
There was a problem hiding this comment.
Changed to a message text:: . Have not rebased, yet.
| === How `T`__x__ (Prepare Tool) works | ||
|
|
||
| [[remap:interpreter-action-on-t]] | ||
| .Interpreter action on a Tx command | ||
| .Interpreter action on a `T`__x__ command |
There was a problem hiding this comment.
IMHO monospace font in headings and sub-headings looks ugly. Anyone who agree/disagree?
There was a problem hiding this comment.
I find it looks very nice.
andypugh
left a comment
andypugh
left a comment
There was a problem hiding this comment.
Approved, if you think it is good to go.
| net tool-change-loop iocontrol.0.tool-change iocontrol.0.tool-changed | ||
| --------------------------------------------------------------------- | ||
| If you for some reason want to remap `Tx` (prepare), the corresponding `iocontrol` pins need to be looped as well. | ||
| If you for some reason want to remap `T`__x__ (prepare), the corresponding `iocontrol` pins need to be looped as well. |
| If cutting a hole requires a reduced velocity then the user would use the following command to set the velocity: | ||
| *M67 E3 Qnn* where nn is the percentage of the velocity desired. | ||
| For example, *M67 E3 Q60* would set the velocity to 60% of the current material's *CutFeedRate*. | ||
| `M67 E3 Q`__nn__ where _nn_ is the percentage of the velocity desired. |
There was a problem hiding this comment.
Also here not formatted correctly.
| `argspec=`__<words>__ `ngc=`__<procname>__ `modalgroup=`___<group>__:: | ||
| The recommended way to call an NGC procedure with a standard argspec parameter conversion. | ||
| Used if argspec is good enough. Note it's not good enough for remapping the `Tx` and `M6`/`M61` tool change codes. | ||
| Used if argspec is good enough. Note it's not good enough for remapping the `T`__x__ and `M6`/`M61` tool change codes. |
There was a problem hiding this comment.
Not formatted correctly. But weird that exactly this works in headings.
There was a problem hiding this comment.
The Tx is wrong since "Tx" is not a command. I would even consider it a grave (a semantic) mistake in the documentation that needs to be fixed. Tx is what I would like to see without that nasty wide separation, but have no idea how to get there.
There was a problem hiding this comment.
Tx is what I would like to see without that nasty wide separation, but have no idea how to get there.
AFAIK there is no way using a syntax that is compatible with our current asciidoc version and also with the current version.
So I suggest to abstain from changes like that until we have migrated to the current asciidoctor version.
There was a problem hiding this comment.
We were discussing the asciidoctor migration somewhere. But yes, I should refrain from anything like that for now.
|
What's the status of this PR? Can it be merged, or closed? |
|
There are some formattings which are not compatible with our asciidoc version. So I would suggest to change that accordingly. |
|
I took the freedom and fixed some formattings and rebased to resolve the merge conflict. |
4 participants
No description provided.