Docs - optics (smoe:docs29_lenovo_100)#2430
Merged
SebKuzminsky merged 5 commits intoLinuxCNC:2.9from Apr 23, 2023
Merged
Conversation
Collaborator
Author
|
The build error is |
hansu
reviewed
Apr 11, 2023
| -n:: name a component when it is a valid option for that component. | ||
|
|
||
| .loadusr Syntax and Examples | ||
| .`loadusr` Syntax and Examples |
Member
There was a problem hiding this comment.
I think it looks not really nice if a caption starts with a command in monospace font.
What about this?
Suggested change
| .`loadusr` Syntax and Examples | |
| .Syntax and Examples of `loadusr` |
Member
There was a problem hiding this comment.
This was meant exemplary for all other occurences in this file (around 9). Sorry that I was not that precise 😇.
Co-authored-by: Hans Unzner <hansunzner@gmail.com>
andypugh
approved these changes
Apr 11, 2023
Collaborator
andypugh
left a comment
andypugh
left a comment
There was a problem hiding this comment.
I am happy to approve docs changes with only a cursory glance.
Member
|
@SebKuzminsky It would be nice if you wait for merging next time until Steffen had found the time to finish the proposed changes. |
hansu
added a commit
that referenced
this pull request
Apr 24, 2023
Collaborator
|
Oops! I didn't notice there were still parts of the conversation to be resolved, sorry, my bad. |
SebKuzminsky
added a commit
that referenced
this pull request
Apr 25, 2023
* origin/2.9: qtvcp -add a simple HAL based panel qtvcp -add panel/screen list to parser help print out gscreen silverdragon: remove MAX_RAPID_OVERRIDE from INI file settings (#2392) docs: fix some formattings docs: reacting to Hansu's comment docs: removing blanks at end of line docs: More translation-revisiting changes. docs: small changes revisiting translations docs: small changes revisiting translations docs: More changes while revisiting translations docs: s/* *// in qtplasmac.adoc docs: smallish corrections while translating docs: more smallish changes during translations docs -mb2hal: make clear that the address has to be decimal integer (#2375) docs: some additions to #2430 more notes Add note and cite original source docs: optics in docs/src/hal/basic-hal.adoc docs: optics docs: better optics in hal/basic docs: More smallish changes while revisiting translations. docs: review o qtdragon.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I must admit to have caught myself not to perform an edit just since all our time is likely better spent on something else. It just also feels wrong to skip over something that the public could hold against us.