Update mqtt-publisher.py fixes #2431#2449
Merged
SebKuzminsky merged 4 commits intoLinuxCNC:2.9from May 4, 2023
mrbubble62:mqtt-publisher
Merged
Update mqtt-publisher.py fixes #2431#2449SebKuzminsky merged 4 commits intoLinuxCNC:2.9from mrbubble62:mqtt-publisher
SebKuzminsky merged 4 commits intoLinuxCNC:2.9from
mrbubble62:mqtt-publisher
Conversation
Fix for missing keys data
Collaborator
|
The code look like it should work. Just a minor question about the exception handling that should be looked at before it is merged. |
Handle case of keys arg not provided
This reverts commit 9d98d81.
petterreinholdtsen
approved these changes
May 2, 2023
Collaborator
petterreinholdtsen
left a comment
petterreinholdtsen
left a comment
There was a problem hiding this comment.
Look good to me.
Collaborator
|
Thanks for this fix @mrbubble62 ! Welcome to LinuxCNC :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for missing keys data