Skip to content

Docs: add document "writing-tests" also to 2.9#2457

Merged
hansu merged 2 commits intoLinuxCNC:2.9from
hansu:docs-add-writing-tests
Jun 6, 2023
Merged

Docs: add document "writing-tests" also to 2.9#2457
hansu merged 2 commits intoLinuxCNC:2.9from
hansu:docs-add-writing-tests

Conversation

@hansu
Copy link
Copy Markdown
Member

@hansu hansu commented Apr 29, 2023

This document was only added to master but I think this should also go into 2.9.
I already spent too much time searching for it in 2.9 🙈.
And yes I am aware that this will probably produce some merge conflicts, so merge to master after this has been merged but I think this is worth it.

@petterreinholdtsen
Copy link
Copy Markdown
Collaborator

The reason I only added it to master is that the majority of new developer should take place in master, and I thus assume the majority of new tests should be written for and committed to master. Why are you looking for it in 2.9?

@hansu
Copy link
Copy Markdown
Member Author

hansu commented May 3, 2023

Because I wanted to modify a test I added to 2.8 and to 2.9 as well.

@hansu
Copy link
Copy Markdown
Member Author

hansu commented May 23, 2023

So is the consensus to not have this in 2.9?

@SebKuzminsky
Copy link
Copy Markdown
Collaborator

I think adding new docs and new tests in 2.9 is a good idea. I support this PR.

@hansu hansu force-pushed the docs-add-writing-tests branch from 20a22c5 to eb7219f Compare May 23, 2023 18:15
@hansu
Copy link
Copy Markdown
Member Author

hansu commented May 23, 2023

Ok 👍 . Rebased and resolved merge conflicts.

@hansu
Copy link
Copy Markdown
Member Author

hansu commented May 28, 2023

I think adding new docs and new tests in 2.9 is a good idea. I support this PR.

So then merge it?

@smoe
Copy link
Copy Markdown
Collaborator

smoe commented Jun 5, 2023

Go for it. What it describes is already valid for the current release and we likely add tests to 2.8 and 2.9 over the next months, so we can steadily improve that description.

@hansu hansu merged commit 40c3176 into LinuxCNC:2.9 Jun 6, 2023
@hansu hansu deleted the docs-add-writing-tests branch June 6, 2023 17:55
@SebKuzminsky
Copy link
Copy Markdown
Collaborator

The version of writing-tests.adoc that was added to 2.9 by this PR is slightly different from the version in master. It looks like a few bugfixes were applied to the doc in master, but not in 2.9. I have backported the bugfixes to 2.9.

@hansu
Copy link
Copy Markdown
Member Author

hansu commented Jun 11, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants