More documentation changes (with an increased level of tolerance) (smoe: Docs29 mac 100)#2470
Merged
hansu merged 2 commits intoLinuxCNC:masterfrom May 5, 2023
Merged
More documentation changes (with an increased level of tolerance) (smoe: Docs29 mac 100)#2470hansu merged 2 commits intoLinuxCNC:masterfrom
hansu merged 2 commits intoLinuxCNC:masterfrom
Conversation
Member
|
Looks good 👍 |
Member
|
This was a bad idea to merge it into master. |
Collaborator
Author
|
Aaargh. It was meant to go to 2.9 - can we fix this somehow? |
Collaborator
Author
|
Me requesting the same against 2.9, possibly? |
Collaborator
|
[Hans Unzner]
This was a bad idea to merge it into master.
If changes will be made to those files in 2.9, it will probably lead
to merge conflicts when merging 2.9 up to master.
This argument is true for any change done to master, as long as the
merge forward from "older" brances strategy is in place. The solution
is to clean up any merge conflicts when merging forward. The
alternative is to stop doing changes only in master, which I assume you
do not suggest.
What is special about these files compared to any other source file in
the repository?
A workaround is to cherry-pick these changes from master into 2.9, and
merge the commit forward into master to bring the two in line.
…--
Happy hacking
Petter Reinholdtsen
|
Member
Nothing =)
Yeah that's probably the easiest option. Done ✔️ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No idea about how you all feel about it - I had promised to myself not to do any more formatting changes, and kept this with respect of the monospace+italic combinations, but I anticipate that we will need to apply the automated translations to ship anything for French, Spanish and Chinese again. And for that we need to keep the line breaks in check.