Skip to content

More documentation changes (with an increased level of tolerance) (smoe: Docs29 mac 100)#2470

Merged
hansu merged 2 commits intoLinuxCNC:masterfrom
smoe:docs29_mac_100
May 5, 2023
Merged

More documentation changes (with an increased level of tolerance) (smoe: Docs29 mac 100)#2470
hansu merged 2 commits intoLinuxCNC:masterfrom
smoe:docs29_mac_100

Conversation

@smoe
Copy link
Copy Markdown
Collaborator

@smoe smoe commented May 5, 2023

No idea about how you all feel about it - I had promised to myself not to do any more formatting changes, and kept this with respect of the monospace+italic combinations, but I anticipate that we will need to apply the automated translations to ship anything for French, Spanish and Chinese again. And for that we need to keep the line breaks in check.

@hansu
Copy link
Copy Markdown
Member

hansu commented May 5, 2023

Looks good 👍

@hansu hansu merged commit 399258c into LinuxCNC:master May 5, 2023
@hansu
Copy link
Copy Markdown
Member

hansu commented May 5, 2023

This was a bad idea to merge it into master.
If changes will be made to those files in 2.9, it will probably lead to merge conflicts when merging 2.9 up to master.

@smoe
Copy link
Copy Markdown
Collaborator Author

smoe commented May 5, 2023

Aaargh. It was meant to go to 2.9 - can we fix this somehow?

@smoe
Copy link
Copy Markdown
Collaborator Author

smoe commented May 5, 2023

Me requesting the same against 2.9, possibly?

@petterreinholdtsen
Copy link
Copy Markdown
Collaborator

petterreinholdtsen commented May 6, 2023 via email

@hansu
Copy link
Copy Markdown
Member

hansu commented May 6, 2023

What is special about these files compared to any other source file in
the repository?

Nothing =)

A workaround is to cherry-pick these changes from master into 2.9, and
merge the commit forward into master to bring the two in line.

Yeah that's probably the easiest option. Done ✔️ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants