resolves #2632 by using tuple instead of list in rigid_tap#2638
Merged
andypugh merged 1 commit intoLinuxCNC:2.9from Sep 15, 2023
Merged
resolves #2632 by using tuple instead of list in rigid_tap#2638andypugh merged 1 commit intoLinuxCNC:2.9from
andypugh merged 1 commit intoLinuxCNC:2.9from
Conversation
the code cleanup in 70771d6 did not include a conversion from list to tuple in the rigid_tap function, resulting in an error.
Contributor
Author
|
wasn't able to rebase the original PR, so I just created a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the code cleanup in 70771d6 did not include a conversion from list to tuple in the rigid_tap function, resulting in an error.