Docs typos#2834
Merged
hansu merged 2 commits intoLinuxCNC:2.9from Jan 6, 2024
Merged
Conversation
Collaborator
|
I assume you are talking about this sentence: The pin names are case-sensitive and there must be no spaces in the strings, neither between the comma-separated pins lists of the "=" signs. I would write "no spaces in the string, nor between the comma-separated pins" instead myself. No native speaker, so not sure if it truly better. |
Member
|
Both is fine I guess. (3) or (4) But I would prefer (1) (Steffens version) or (2) (Petters version). |
Collaborator
Author
|
Heya, please then ("either" of you, pun intended) merge my request since this saves time, is apparently good enough, and closest to the original.
But I would prefer (1) (Steffens version) or (2) (Petters version).
|
Member
|
I agree :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As usual, something spotted while translating.
Please kindly confirm my interpretation "neither between" in docs/src/drivers/hal_gpio.adoc line 57.
Admittedly this PR was mostly motivated as a technical excercise to work with WSL.