Skip to content

Update interp_convert.cc: Fix bug in G43.2#2991

Merged
andypugh merged 1 commit intoLinuxCNC:2.9from
Sigma1912:patch-1
Jun 8, 2024
Merged

Update interp_convert.cc: Fix bug in G43.2#2991
andypugh merged 1 commit intoLinuxCNC:2.9from
Sigma1912:patch-1

Conversation

@Sigma1912
Copy link
Copy Markdown
Contributor

@Sigma1912 Sigma1912 commented May 31, 2024

Fix error when using eg 'G43.2 z1 ' (ie H word is omitted)
No point trying to find the tool using the h_number when the user specified axes parameters instead.

Fix error in G43.2  <axes> when H word is omitted.
@Sigma1912 Sigma1912 changed the title Update interp_convert.cc Update interp_convert.cc: Fix bug in G43.2 May 31, 2024
@Sigma1912
Copy link
Copy Markdown
Contributor Author

This is in line with the original commit:
2df2871

I'm not sure what happened in the commits after that as the code seems to revert back and then the current form appears here
https://github.com/LinuxCNC/linuxcnc/blob/3765decc8626c191c0c2797f91ea4ffff6ab7513/src/emc/rs274ngc/interp_convert.cc

@andypugh andypugh merged commit 62ff6e0 into LinuxCNC:2.9 Jun 8, 2024
@Sigma1912 Sigma1912 deleted the patch-1 branch September 1, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants