Deduplicate hm2 driver code and constants#3225
Merged
pcw-mesa merged 2 commits intoLinuxCNC:masterfrom Dec 14, 2024
Merged
Conversation
…ucture was put in place by the new hm2_spix driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The evolution of the SPI drivers has created a bit of copy-paste duplication of code and constants. This PR cleans that up and uses the files created by the hm2_spix driver previously. It is not necessary to backport this cleanup part.
This PR also fixes the old and original hm2_spi driver to actually work on any RPi board. This old driver should not be needed any more and is superseded by hm2_spix, but deleting it now is probably not a good idea. Better fix it than having a non-functional driver in the tree. It may also be a good thing to backport this fix to the 2.9 branch (and older if still supported).