Fix more shellcheck problems#3304
Merged
andypugh merged 4 commits intoLinuxCNC:masterfrom Feb 6, 2025
Merged
Conversation
Also includes missing double quotes and few other simple changes.
smoe
reviewed
Jan 31, 2025
smoe
reviewed
Jan 31, 2025
smoe
reviewed
Jan 31, 2025
smoe
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mostly about
cd || exitbecause cd may fail. Also includes missing double quotes and few other simple changes. The file-set is primarily config/demo related. The patch-set was created in cooperation with @smoe.