gmoccapy: fix increasing window size on edit (2.9)#3330
Merged
hansu merged 1 commit intoLinuxCNC:2.9from Feb 12, 2025
Merged
Conversation
For some translations the text for the search/replace buttons is too wide to fit the smallest window size. The result is that the window width increases in edit mode. Changing the text to icons for the undo and redo buttons gives enough space.
hansu
changed the title
Collaborator
|
Hallo Hans, i like the solution with the icon button. So go ahead! Norbert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some translations the text for the search/replace buttons is too wide to fit the smallest window size. The result is that the window width increases in edit mode:
Changing the text to icons for the undo and redo buttons resolves this:
@gmoccapy Are you okay with the button solution or do you have a better proposal?
For the master branch I thought to optimize this further, maybe similar to how it's done in kate