Fix -Wextra in RT non-componentized code#3344
Merged
andypugh merged 1 commit intoLinuxCNC:masterfrom Mar 2, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the non-componentized real-time part in the -Wextra warnings cleanup.
It turns out that CFLAGS are not propagated to the RT compile causing the code to be compiled without -Wextra. A whole list of issues turn up when propagating the -Wextra option. The fixed warnings include:
All warnings pertaining to above list are fixed in this PR when compiling uspace. The fixes in the components will be put forward in a separate PR.
(Note, this PR is split off from #3333, now marked WIP, to form two new PRs; this one and one upcoming)