Fix PktUART crash and cleanup modcompile/template#3387
Closed
BsAtHome wants to merge 4 commits intoLinuxCNC:masterfrom
Closed
Fix PktUART crash and cleanup modcompile/template#3387BsAtHome wants to merge 4 commits intoLinuxCNC:masterfrom
BsAtHome wants to merge 4 commits intoLinuxCNC:masterfrom
Conversation
Fix modcompile removal of temporary files.
…variable reference.
Collaborator
|
Do you think that this should go into 2.9 instead? It seems to be largely bug-fixes. |
Contributor
Author
|
It needs to go in both because it is a crash-bug. I'll backport it too. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a crash in PktUART hm2_pktuart_send() because a queued read is issued with a local stack variable. The stack will be trashed when the queued read is resolved because the variable no longer exists. This PR removed the queued read. We have to assume that the send procedure succeeds.
The module compile makefile is updated to use -O2 instead of -Os and adds -Wextra (it was missed in #3363).
Also, the modcompile program is updated to take command-line arguments (see also #3380) and now properly removes temporary files, unless instructed to keep them. The modbus template is fixed to handle -O2 and -Wextra without warnings. Additionally, some known divide-by-zero errors in the template have been guarded as well.