Skip to content

[ci] publish releases with artifacts#3588

Merged
andypugh merged 2 commits intoLinuxCNC:2.9from
f355:2.9
Oct 27, 2025
Merged

[ci] publish releases with artifacts#3588
andypugh merged 2 commits intoLinuxCNC:2.9from
f355:2.9

Conversation

@f355
Copy link
Copy Markdown
Contributor

@f355 f355 commented Oct 24, 2025

  • before this, CI built packages but didn’t create a release with downloadable .deb's, now it does, for both amd64 and arm64 architectures and three Debian versions: bookworm, trixie and sid.
  • in order to make the .deb versioning better, version detection has been changed - on tagged commits, packages use the tag verbatim; otherwise the prevous logic is preserved.
  • tag matching on master is derived from VERSION (major.minor) instead of hard‑coded. This yields versions that align with release tags and clearer pre‑release identifiers.

* before this, CI built packages but didn’t create a release with downloadable .deb's, now it does, for both amd64 and arm64 architectures and three Debian versions: bookworm, trixie and sid.
* in order to make the .deb versioning better, version detection has been changed - on tagged commits, packages use the tag verbatim; otherwise the prevous logic is preserved.
* tag matching on master is derived from VERSION (major.minor) instead of hard‑coded. This yields versions that align with release tags and clearer pre‑release identifiers.
@f355
Copy link
Copy Markdown
Contributor Author

f355 commented Oct 24, 2025

this is a backport of #3587 to the 2.9 version branch. an example release is here: https://github.com/f355/linuxcnc/releases/tag/v2.9.7-gh2

Comment thread .github/workflows/ci.yml
eatmydata gpg --homedir="${PWD}/gnupg" --output /etc/apt/trusted.gpg.d/linuxcnc-deb-archive.gpg --export 3CB9FD148F374FEF
DIST=$(echo ${{matrix.image}} | cut -d : -f 2)
eatmydata add-apt-repository "deb http://linuxcnc.org $DIST base"
eatmydata apt-get --quiet update
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andypugh this step was failing for me: https://github.com/f355/linuxcnc/actions/runs/18779065074/job/53580431559. I've removed it since it's not strictly needed, but you might want to take a look at the file permissions in the bullseye repo.

Copy link
Copy Markdown
Contributor Author

@f355 f355 Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.linuxcnc.org/dists/bullseye/2.9-uspace/ - it's there, but the permissions are wrong and arm64 stuff seems to be missing. in any case, this deleted snippet did not do anything useful anyway, so I reckon it's safe to get rid of it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah, it just gets HTTP 403 for some reason, it's not a signature error. go on with your weekend mate, we can take this when you're back.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the problem eventually. Wrong permissions on the actual base/binary-arm64 folder. Should be fixed now.

@andypugh
Copy link
Copy Markdown
Collaborator

andypugh commented Oct 24, 2025

The builds all worked once I fixed the repo permissions and re-ran the CI. but it didn't create a release, presumably because there wasn't a tag. Which is rather odd as there was a tag when I pushed it.
I think that now it will have to wait until Sunday.

https://github.com/LinuxCNC/linuxcnc/actions/runs/18786082764

@andypugh
Copy link
Copy Markdown
Collaborator

This looks like success: https://github.com/LinuxCNC/linuxcnc/releases/tag/v2.9.7

Thanks. This is great.

@f355
Copy link
Copy Markdown
Contributor Author

f355 commented Oct 27, 2025

fantastic! I guess this PR should be closed now?

@andypugh andypugh merged commit 733477c into LinuxCNC:2.9 Oct 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants