libnml,emc: strtok -> strtok_r #3771
Open
+20
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pedantic mode enable: isn't it " |
Collaborator
Author
Addressed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strtok function is not reentrant. It has an internal static char* memorizing where the function has last split the string when it is called again. As a consequence, its calls cannot be nested (as in an outer and inner loop) and also it cannot be used at the same time within two different threads.
The strtok_r function expects the programmer to take care of that internal variable, instead. This is what this patch is all about. The remnant strtok usage of LinuxCNC are for the binaries that implement remote access to LinuxCNC. Those would be more intrusive to transition to strtok_r and are not expected to be of immediate relevance, so this is not addressed in this stable branch.