Vismach / Puma: Make the Puma simulator geometry match the kinematics.#382
Merged
SebKuzminsky merged 1 commit intoLinuxCNC:2.7from Dec 22, 2017
andypugh:pumafix
Merged
Vismach / Puma: Make the Puma simulator geometry match the kinematics.#382SebKuzminsky merged 1 commit intoLinuxCNC:2.7from andypugh:pumafix
SebKuzminsky merged 1 commit intoLinuxCNC:2.7from
andypugh:pumafix
Conversation
Signed-off-by: andy pugh <andy@bodgesoc.org>
Collaborator
|
This looks good to me. Passes the test suite. I don't understand the details of the changes to pumakins but I trust that @rudydupreez and @andypugh do. The merge from 2.7 to master might be wonky due to joints/axes changes to the configs, but that shouldn't stop us from merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: andy pugh andy@bodgesoc.org