Detect and error on nested/invalid subroutine definitions in named subs#3886
Merged
andypugh merged 1 commit intoLinuxCNC:masterfrom Mar 30, 2026
Merged
Detect and error on nested/invalid subroutine definitions in named subs#3886andypugh merged 1 commit intoLinuxCNC:masterfrom
andypugh merged 1 commit intoLinuxCNC:masterfrom
Conversation
grandixximo
force-pushed
the
issue-3880-fix
branch
2 times, most recently
from
560c271 to
daf41c9
Compare
Collaborator
|
Can I suggest adding a test to the testsuite for this? |
grandixximo
force-pushed
the
issue-3880-fix
branch
from
daf41c9 to
5befcf2
Compare
The parser silently ignored sub definitions inside called subroutines, causing wrong parameters and premature returns. Numbered subs after a named endsub polluted the global offset map and conflicted across files. - Add nesting checks in read and execute phases at call_level > 0 - Block forward-seek for subs at call_level > 0 when no file exists - Let control_back_to errors propagate without generic overwrite - Update o-code docs with nesting example and new error conditions Ref: LinuxCNC#3880
grandixximo
force-pushed
the
issue-3880-fix
branch
from
5befcf2 to
5b86d5a
Compare
Author
@andypugh tests were added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser silently ignored sub definitions inside called subroutines, causing wrong parameters and premature returns. Numbered subs after a named endsub polluted the global offset map and conflicted across files.
Ref: #3880