Skip to content

Fix wrong INT64_MIN/MAX defines and naked preprocessor expansion #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BsAtHome merged 1 commit into from
Apr 29, 2026
+6 −6
Merged

Fix wrong INT64_MIN/MAX defines and naked preprocessor expansion #3981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/hal/components/latencybinstream.comp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ variable hal_stream_t fifo;
variable rtapi_u64 nsamples;
variable rtapi_u64 sum;
variable rtapi_u64 sq_sum;
variable rtapi_s64 lat_min = INT64_MAX;
variable rtapi_s64 lat_max = INT64_MIN;
variable rtapi_s64 lat_min = RTAPI_INT64_MAX;
variable rtapi_s64 lat_max = RTAPI_INT64_MIN;

license "GPL2+";
license "GPL";
author "B.Stultiens";
;;

Expand Down Expand Up @@ -126,8 +126,8 @@ FUNCTION(_) {
rtapi_s64 nsbs = nsbinsize; // May not be zero, important to avoid divide by zero
if (first || binmax != last_binmax || !nsbs) {
first = 0;
lat_min = INT64_MAX;
lat_max = INT64_MIN;
lat_min = RTAPI_INT64_MAX;
lat_max = RTAPI_INT64_MIN;
ptail.u = ntail.u = 0;
memset(pbins, 0, sizeof(pbins));
memset(nbins, 0, sizeof(nbins));
Expand Down
2 changes: 1 addition & 1 deletion src/hal/hal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,7 +992,7 @@ extern void hal_stream_wait_writable(hal_stream_t *stream, sig_atomic_t *stop);

/** HAL_STATIC_ASSERT wrapper for compile time asserts
*/
#if __STDC_VERSION__ >= 202311L || __cplusplus
#if __STDC_VERSION__ >= 202311L || defined(__cplusplus)
#define HAL_STATIC_ASSERT(expression, message) static_assert((expression), message)
#else
/* _Static_assert: GCC extension, in C standard since C11, deprecated in favour of
Expand Down
Loading