ci: install adduser explicitly in package-arch test step#4018
Merged
Conversation
The test step runs 'eatmydata adduser ... testrunner' but never installs adduser. It was pulled transitively via Recommends on the installed .deb files; sid no longer pulls it, so builds fail with 'eatmydata: unable to find adduser in PATH'. Add it to the existing sudo install so testrunner setup does not depend on Recommends.
Contributor
Author
|
that makes no sense, error on linuxcnc/linuxcnc ??? |
Contributor
Author
|
We either hit some CI limit, or github is just 💩 today |
2 tasks
Contributor
|
You can now rebase you other 2.9 PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of master commit f9b3632 onto 2.9.
The test step runs
eatmydata adduser ... testrunnerbut never installsadduser. It was pulled transitively via Recommends on the installed.debfiles; sid no longer pulls it, so builds fail with:Add it to the existing sudo install so testrunner setup does not depend on Recommends.
2.9's
ci.ymlhas the same vulnerable line (line 169 pre-patch) as master had, so the fix is identical.