docs: fix three broken cross-reference targets#4105
Open
grandixximo wants to merge 1 commit into
Open
Conversation
The remaining broken links surfaced once HTML link checking actually runs (see the checkref fix): - qtvcp-widgets.adoc: link to halcmd.1.html#COMMANDS; the section's generated id is _commands. - linuxcncrsh.1.adoc (x3): links to #_linuxcnc_subcommands; the SUBCOMMANDS section's generated id is _subcommands. - plasma-cnc-primer.adoc: the <<...>> xref title contained [AXIS_<letter>], whose '>' broke the xref so the resolver could not qualify it. Use the '[AXIS_l]' wording the other references to this anchor already use, so it resolves as a normal cross-document link.
Contributor
Did it break the asciidoctor resolver or your resolver? If if was yours, then it needs fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last broken links surfaced once link checking actually runs (companion to the checkref fix, #4104). Two are stale fragment ids (the real generated ids are
_commandsand_subcommands). The third, in plasma-cnc-primer.adoc, had[AXIS_<letter>]as the xref title; the>broke the xref so the resolver could not qualify it, switched to the[AXIS_l]wording the anchor's other references already use.First two resolve immediately; the third resolves via the resolver in #4100.