radiobutton: fix unused-parameter build error#4139
Merged
Conversation
Component ignores period, so generated FUNCTION kept an unused long period and tripped -Werror=unused-parameter. Add 'option period no'.
Contributor
|
Thank you for this! |
Contributor
Author
|
No problem, has to be merged, we have a broken tree... |
NTULINUX
approved these changes
Jun 8, 2026
Contributor
Author
|
Good Morning, Bertho :-) |
Contributor
|
@hansu broke the tree when merging 2.9 into the master branch. Any merge must be compiled from a clean slate locally before committing or you risk breaking the tree, like happened here. |
Member
|
Sorry I forgot about the adaptions needed for halcomp in master. But yeah a testbuild would have been better. |
Member
|
Always a pleasure doing these merges... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
radiobutton.comp ignores
period, but defaults tooption periodon, so the generated FUNCTION carried an unusedlong periodand broke the RT build under-Werror=unused-parameter. Addingoption period no;drops the parameter.master currently fails
rip-and-test/rip-and-test-clangbecause of this.@BsAtHome @hansu @andypugh please merge.