Bspi updates

[sleepybishop]

been working on bspi driver, found a few bugs.

for context:
https://forum.linuxcnc.org/24-hal-components/34049-bspi-problems#106773

[andypugh]

Why reduce the maximum number of bspi interfaces?

[sleepybishop]

not reducing, according to regmap the base addresses for bspi modules are
0x5500 BSPI FIFO port 0
0x5540 BSPI FIFO port 1
0x5580 BSPI FIFO port 2
0x55C0 BSPI FIFO port 3

and then
0x5600 BSPI channel descriptor setup registor 0

so theres only room for 4 bspi interfaces

unless we do a big refactor and resuse the dbspi address space, as far as i cant tell the only difference is one parameter in hostmot2.vhd (gatedcs= true) for dbspi. if we set that via other means then there is enough address space for 4 more bspi instances. but that would be a pretty big change

[andypugh]

so theres only room for 4 bspi interfaces

4 interfaces per FPGA card. But a system can have many FPGA cards.

[sleepybishop]

right, ok ill revert that change.

[jepler]

Also the memory map file is really just a guideline for how things typically are. A firmware could move those to any other address and have room for more BSPI instances. The hostmot2 driver will read the correct addresses from the IDROM, and does not use the addresses and ranges shown in the regmap.txt.

[sleepybishop]

i removed all commits that deal with addresses of the registers, i have more work to do to sort all that out.

[jepler]

This added function appears to be unused. If that is correct, can you please remove it?

[jepler]

you change the function signature here, but don't change the declaration or use sites until a later commit. Please move to the appropriate commit.

Symptom: Compiling at this ref,

hal/drivers/mesa-hostmot2/bspi.c:213:5: error: conflicting types for ‘hm2_bspi_setup_chan’
 int hm2_bspi_setup_chan(char *name, int chan, int cs, int bits, float mhz,
     ^~~~~~~~~~~~~~~~~~~
In file included from hal/drivers/mesa-hostmot2/bspi.c:25:0:
hal/drivers/mesa-hostmot2/hostmot2.h:1304:5: note: previous declaration of ‘hm2_bspi_setup_chan’ was here
 int hm2_bspi_setup_chan(char *name, int chan, int cs, int bits, float mhz,
     ^~~~~~~~~~~~~~~~~~~
Makefile:1005: recipe for target 'objects/rthal/drivers/mesa-hostmot2/bspi.o' failed

[sleepybishop]

@jepler, those two issues should be addressed now, thank you.

[jepler]

@sleepybishop thank you for these fixes.