Provide a clearer error message when exceeding hal pin name length#494
Merged
jepler merged 1 commit intoLinuxCNC:masterfrom Sep 2, 2018
Merged
Provide a clearer error message when exceeding hal pin name length#494jepler merged 1 commit intoLinuxCNC:masterfrom
jepler merged 1 commit intoLinuxCNC:masterfrom
Conversation
The maximum length of a pin name is calculated after an internal construction of the string, which is not obvious to the user. The error message will now print the constructed string, so that it becomes clear why a "component_name.pin_name" combination, that is still shorter than the maximum allowed size, fails. Signed-off-by: Sergey 'Jin' Bostandzhyan <jin@mediatomb.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maximum length of a pin name is calculated after an internal
construction of the string, which is not obvious to the user. The error
message will now print the constructed string, so that it becomes clear
why a "component_name.pin_name" combination, that is still shorter than the
maximum allowed size, fails.
Signed-off-by: Sergey 'Jin' Bostandzhyan jin@mediatomb.cc