Apply minimum displacement checks consistently between canon and TP.#551
Merged
andypugh merged 1 commit intoLinuxCNC:2.7from Apr 28, 2019
Merged
Conversation
fixes LinuxCNC#550 1) Change the minimum displacement calculation in PmCartLineInit to use infinity-norm (i.e. max component) rather than the vector magnitude. This is consistent with how Canon checks for minimum displacement 2) Apply the minimum displacement checks in canon with a threshold based on user units, so that the cutoffs are the same for both the TP and canon. To be clear, this is an ugly way to fix the issue. The TP has to repeat the work that canon does, and do so the exact same way to avoid weird edge cases. The long-term fix needs to be more robust, perhaps with an API change to enforce canon's choice of linear / angular or pure-angular move.
robEllenberg
force-pushed
the
bug-550-tp-canon-displacement-checks
branch
from
599145a to
10c3678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
infinity-norm (i.e. max component) rather than the vector magnitude.
This is consistent with how Canon checks for minimum displacement
on user units, so that the cutoffs are the same for both the TP and
canon.
To be clear, this is an ugly way to fix the issue. The TP has to repeat
the work that canon does, and do so the exact same way to avoid weird
edge cases. The long-term fix needs to be more robust, perhaps with an
API change to enforce canon's choice of linear / angular or pure-angular
move.