fix importing of certain stls in vismach#583
Closed
sleepybishop wants to merge 1 commit intoLinuxCNC:masterfrom
Closed
fix importing of certain stls in vismach#583sleepybishop wants to merge 1 commit intoLinuxCNC:masterfrom
sleepybishop wants to merge 1 commit intoLinuxCNC:masterfrom
Conversation
Collaborator
|
Are you convinced that this is always better than the original version? |
Contributor
Author
|
yes i'm certain, before this code path would error out because [x1,x2,y1,y2,z1,z2] were not defined. an example stl to trigger the problem can be found here: |
Collaborator
|
OK, if the original was actually buggy and crashy, then we should merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'm trying to integrate a 6dof robot arm with linuxcnc, been having problems with kinematics so i thought i'de try and model in vismach. once in a while an stl would fail to import, with the small changes here the failed stl imports went away.
submitting for merge consideration in case it's helpful, if not please disregard.