refactor(match2): use grid layout for ban table#7586
Merged
Conversation
hjpalpha
approved these changes
Jun 1, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
seems reasonable on phone
Rathoz
reviewed
Jun 1, 2026
Rathoz
approved these changes
Jun 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors match summary veto/ban displays by migrating them to Widget3 components and switching the layout from HTML tables to CSS grid-based containers, aligning with the newer GeneralCollapsible pattern.
Changes:
- Converted Map Veto and Character Ban Table widgets to Widget3 functional components using
Module:Widget/Component+Module:Widget/Html. - Replaced table-based markup with grid-based containers and added new
.brkts-popup-veto*styling. - Tweaked
GeneralCollapsibleheader title centering and updated type annotation forpreProcessMapVeto.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| stylesheets/commons/Miscellaneous.scss | Centers collapsible header title within the grid header. |
| stylesheets/commons/Brackets.scss | Introduces .brkts-popup-veto grid layout and moves veto/ban icon styling to the new structure. |
| lua/wikis/commons/Widget/Match/Summary/MapVetoStart.lua | Converts MapVetoStart to Widget3 and outputs grid-row markup. |
| lua/wikis/commons/Widget/Match/Summary/MapVetoRound.lua | Converts MapVetoRound to Widget3 and outputs grid-row markup (but currently breaks map links due to field mismatch). |
| lua/wikis/commons/Widget/Match/Summary/MapVeto.lua | Replaces table+collapsible usage with GeneralCollapsible + grid container. |
| lua/wikis/commons/Widget/Match/Summary/Characters.lua | Converts Characters to Widget3 functional component with defaultProps. |
| lua/wikis/commons/Widget/Match/Summary/CharacterBanTable.lua | Converts ban table to Widget3 and renders rows via grid layout + GeneralCollapsible. |
| lua/wikis/commons/Widget/Match/Summary/Character.lua | Converts Character to Widget3 functional component with defaultProps. |
| lua/wikis/commons/MatchSummary/Base.lua | Updates preProcessMapVeto return annotation to MapVetoProps?. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rathoz
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
How did you test this change?
dev + browser dev tools