fix(match2): broken links in valorant map veto display

[ElectricalBoy]

Summary

Lua-Modules/lua/wikis/commons/MatchSummary/Base.lua

Lines 327 to 329 in 64f0ccd

	if options.game then
	return {name = map, link = map .. '/' .. options.game}
	end

Lua-Modules/lua/wikis/valorant/MatchSummary.lua

Line 47 in 64f0ccd

MatchSummaryWidgets.MapVeto(MatchSummary.preProcessMapVeto(match.extradata.mapveto, {game = match.game}))

The game = match.game option passed into MatchSummary.preProcessMapVeto caused the returned links to have /val appended to the returned link. This wasn't a problem until #7586 as the link was never used for display due to key inconsistency (see #7586 (comment)).

This PR fixes the above issue by adding a LPDB map check, similar to how match pages handle map veto.

How did you test this change?

dev

[hjpalpha]

could potentially throw if a "game" is used that is not set in module imfo
can test later this week (only on mobile today)

[ElectricalBoy]

could potentially throw if a "game" is used that is not set in module imfo

map infobox already includes game input check as shown below, so it is safe enough to assume that it never throws

Lua-Modules/lua/wikis/commons/Infobox/Map.lua

Lines 116 to 127 in 64f0ccd

	---Returns the respective game for this map
	---@param args table
	---@return string?
	function Map:getGame(args)
	local game = Game.name{
	game = args.game,
	useDefault = args.useDefaultGame
	}
	assert(game, 'Missing or invalid game specified')
	---@cast game -nil
	return game
	end

Lua-Modules/lua/wikis/commons/Infobox/Map.lua

Lines 163 to 169 in 64f0ccd

	extradata = Table.merge(
	creatorsToLpdbData(),
	{
	game = self:getGame(args),
	modes = self:getGameModes(args),
	}
	)

[hjpalpha]

could potentially throw if a "game" is used that is not set in module imfo

map infobox already includes game input check as shown below, so it is safe enough to assume that it never throws

Lua-Modules/lua/wikis/commons/Infobox/Map.lua

Lines 116 to 127 in 64f0ccd

	---Returns the respective game for this map
	---@param args table
	---@return string?
	function Map:getGame(args)
	local game = Game.name{
	game = args.game,
	useDefault = args.useDefaultGame
	}
	assert(game, 'Missing or invalid game specified')
	---@cast game -nil
	return game
	end

Lua-Modules/lua/wikis/commons/Infobox/Map.lua

Lines 163 to 169 in 64f0ccd

	extradata = Table.merge(
	creatorsToLpdbData(),
	{
	game = self:getGame(args),
	modes = self:getGameModes(args),
	}
	)

there are exceptions
you could test on https://liquipedia.net/starcraft2/Sunrise_Cup/2021_National_Day

[ElectricalBoy]

there are exceptions
you could test on https://liquipedia.net/starcraft2/Sunrise_Cup/2021_National_Day

I don't see how the linked page is relevant to this PR?
sc2 doesn't call MatchSummaryBase.preProcessMapVeto in the first place, not to mention that it stores nothing to the match2 table

[hjpalpha]

there are exceptions
you could test on https://liquipedia.net/starcraft2/Sunrise_Cup/2021_National_Day

I don't see how the linked page is relevant to this PR? sc2 doesn't call MatchSummaryBase.preProcessMapVeto in the first place, not to mention that it stores nothing to the match2 table

ah right we don't use this

[hjpalpha]

/shrug

[mbergen]

Seems like worldoftanks would like the same treatment: https://discord.com/channels/93055209017729024/372075546231832576/1511717722977734766