Skip to content

LF-5367 Survey crashes after browser auto translation is enabled#4236

Merged
SayakaOno merged 2 commits into
integrationfrom
LF-5367-survey-crashes-after-browser-auto-translation-is-enabled
Jul 2, 2026
Merged

LF-5367 Survey crashes after browser auto translation is enabled#4236
SayakaOno merged 2 commits into
integrationfrom
LF-5367-survey-crashes-after-browser-auto-translation-is-enabled

Conversation

@kathyavini

@kathyavini kathyavini commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Description

This was not our bug and it is not our fix!

Although I hate to cache-bust the SurveyJS code, this version bump includes a fix for the very crash that Denis discovered so it seems worth getting in. I tried it with our existing surveys and noticed no regressions.

Jira link: https://lite-farm.atlassian.net/browse/LF-5367

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini self-assigned this Jun 30, 2026
@kathyavini
kathyavini requested review from a team as code owners June 30, 2026 23:39
@kathyavini
kathyavini requested review from SayakaOno and removed request for a team June 30, 2026 23:39
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedsurvey-react-ui@​2.5.30981009598100
Addedsurvey-core@​2.5.301001009599100

View full report

@kathyavini kathyavini added the bug Something isn't working label Jul 2, 2026

@SayakaOno SayakaOno left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad there was a fix!

@SayakaOno
SayakaOno added this pull request to the merge queue Jul 2, 2026
Merged via the queue into integration with commit 71f677e Jul 2, 2026
6 checks passed
@SayakaOno
SayakaOno deleted the LF-5367-survey-crashes-after-browser-auto-translation-is-enabled branch July 2, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants