Skip to content

LF-5370 Completed survey can be retaken by using the browser Back button#4246

Merged
SayakaOno merged 2 commits into
integrationfrom
LF-5370-completed-survey-can-be-retaken-by-using-the-browser-back-button
Jul 3, 2026
Merged

LF-5370 Completed survey can be retaken by using the browser Back button#4246
SayakaOno merged 2 commits into
integrationfrom
LF-5370-completed-survey-can-be-retaken-by-using-the-browser-back-button

Conversation

@kathyavini

Copy link
Copy Markdown
Collaborator

Description

As Loïc indicated, this is not a particularly important bug, but the fix is minimal as well.

Jira link: https://lite-farm.atlassian.net/browse/LF-5370

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Tested on Cathi Gao and FAO TAPE. If desired, can also be tested on a modified testing FAO TAPE by pointing surveyConfig.ts to this version uploaded to the local DO bucket:

//surveyConfig.ts -- SURVEY_INFO.tape
versionsByCountry: { default: 'fao_local_no_required', AU: 'au' },

fao_local_no_required.json is identical to the prod-served fao.json, except that it has no required questions, making submission MUCH easier.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini self-assigned this Jul 3, 2026
@kathyavini
kathyavini requested review from a team as code owners July 3, 2026 18:47
@kathyavini kathyavini added the bug Something isn't working label Jul 3, 2026
@kathyavini
kathyavini requested review from SayakaOno and removed request for a team July 3, 2026 18:47
Whether the back button actually routes to Insights depends on how the user got to the survey; direct navigation to survey is also technically possible

@SayakaOno SayakaOno left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SayakaOno
SayakaOno added this pull request to the merge queue Jul 3, 2026
Merged via the queue into integration with commit 39106fa Jul 3, 2026
6 of 7 checks passed
@SayakaOno
SayakaOno deleted the LF-5370-completed-survey-can-be-retaken-by-using-the-browser-back-button branch July 3, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants