fix(common-lint): resolve clang-format version from submodule - #817
Merged
Conversation
Replace the hardcoded CLANG_FORMAT_VERSION env var with a dynamic resolution step that reads the pinned clang-format version from the lizardbyte-common submodule's pyproject.toml. Falls back to the latest version with a warning if the submodule or pin is unavailable. Also replaces the DoozyX/clang-format-lint-action with a direct clang-format shell invocation for the diff step, removing the dependency on that third-party action.
|
ReenigneArcher
marked this pull request as ready for review
July 28, 2026 01:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Replace the hardcoded CLANG_FORMAT_VERSION env var with a dynamic resolution step that reads the pinned clang-format version from the lizardbyte-common submodule's pyproject.toml. Falls back to the latest version with a warning if the submodule or pin is unavailable.
Also replaces the DoozyX/clang-format-lint-action with a direct clang-format shell invocation for the diff step, removing the dependency on that third-party action.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.