Skip to content

build(homebrew): fix boost linking#3296

Merged
ReenigneArcher merged 1 commit intomasterfrom
build/homebrew/fix-boost-linking
Oct 12, 2024
Merged

build(homebrew): fix boost linking#3296
ReenigneArcher merged 1 commit intomasterfrom
build/homebrew/fix-boost-linking

Conversation

@ReenigneArcher
Copy link
Copy Markdown
Member

@ReenigneArcher ReenigneArcher commented Oct 12, 2024

Description

Fixes brew Ubuntu build, by changing default behavior of boost linking (static linking seems to be broken at the moment). Also install boost from brew, instead of relying on fetch content.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.75%. Comparing base (50261bf) to head (2e80708).
Report is 84 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #3296    +/-   ##
=======================================
  Coverage    9.75%   9.75%            
=======================================
  Files         101     101            
  Lines       17977   17977            
  Branches     8420    8420            
=======================================
  Hits         1753    1753            
+ Misses      13480   13330   -150     
- Partials     2744    2894   +150     
Flag Coverage Δ
Linux 7.27% <ø> (ø)
Windows 5.10% <ø> (ø)
macOS-13 10.56% <ø> (ø)
macOS-14 10.01% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

@ReenigneArcher
Copy link
Copy Markdown
Member Author

@Hazer just FYI

@ReenigneArcher ReenigneArcher marked this pull request as ready for review October 12, 2024 16:43
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) October 12, 2024 16:44
@ReenigneArcher ReenigneArcher merged commit 25ed2d5 into master Oct 12, 2024
@ReenigneArcher ReenigneArcher deleted the build/homebrew/fix-boost-linking branch October 12, 2024 17:08
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant