build(homebrew): fix boost linking#3296
Merged
ReenigneArcher merged 1 commit intomasterfrom Oct 12, 2024
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3296 +/- ##
=======================================
Coverage 9.75% 9.75%
=======================================
Files 101 101
Lines 17977 17977
Branches 8420 8420
=======================================
Hits 1753 1753
+ Misses 13480 13330 -150
- Partials 2744 2894 +150
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
Author
|
@Hazer just FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes brew Ubuntu build, by changing default behavior of boost linking (static linking seems to be broken at the moment). Also install boost from brew, instead of relying on fetch content.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist