Skip to content

docs(readme): use official winget badge#3374

Merged
ReenigneArcher merged 1 commit intoLizardByte:masterfrom
sitiom:patch-1
Nov 5, 2024
Merged

docs(readme): use official winget badge#3374
ReenigneArcher merged 1 commit intoLizardByte:masterfrom
sitiom:patch-1

Conversation

@sitiom
Copy link
Copy Markdown
Contributor

@sitiom sitiom commented Nov 5, 2024

Description

shields.io now supports Winget directly as of badges/shields#10245 🥳

Screenshot

https://img.shields.io/winget/v/LizardByte.Sunshine?style=for-the-badge&logo=data:image/png
Winget Version

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 5, 2024

@ReenigneArcher
Copy link
Copy Markdown
Member

Thanks for the PR. I'm not sure about merging this though as it looks like they're using the GitHub api and therefore limited to 5000 requests per hour, which they will easily hit once people discover the new badge.

@sitiom
Copy link
Copy Markdown
Contributor Author

sitiom commented Nov 5, 2024

I believe they have a token pool (read-only public access) shared from other users to help increase the rate limit. You can authorize from the OAuth app to "donate" one:
image

@ReenigneArcher
Copy link
Copy Markdown
Member

That's a nice feature, but I can't afford to be randomly rate limited when I am trying to contribute to my own projects.

Anyway, giving it more thought, I think it's okay to merge this as I don't recall issues with the other GitHub badges.

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) November 5, 2024 13:41
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.06%. Comparing base (4973448) to head (d70b699).
Report is 89 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3374    +/-   ##
========================================
  Coverage   11.06%   11.06%            
========================================
  Files          99       99            
  Lines       17237    17237            
  Branches     8035     8035            
========================================
  Hits         1908     1908            
- Misses      12643    12784   +141     
+ Partials     2686     2545   -141     
Flag Coverage Δ
Linux 8.35% <ø> (ø)
Windows 5.23% <ø> (ø)
macOS-13 13.63% <ø> (+0.01%) ⬆️
macOS-14 12.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 740bbb6 into LizardByte:master Nov 5, 2024
@sitiom sitiom deleted the patch-1 branch November 5, 2024 14:06
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants