docs(readme): use official winget badge#3374
docs(readme): use official winget badge#3374ReenigneArcher merged 1 commit intoLizardByte:masterfrom sitiom:patch-1
Conversation
|
|
Thanks for the PR. I'm not sure about merging this though as it looks like they're using the GitHub api and therefore limited to 5000 requests per hour, which they will easily hit once people discover the new badge. |
|
I believe they have a token pool (read-only public access) shared from other users to help increase the rate limit. You can authorize from the OAuth app to "donate" one: |
|
That's a nice feature, but I can't afford to be randomly rate limited when I am trying to contribute to my own projects. Anyway, giving it more thought, I think it's okay to merge this as I don't recall issues with the other GitHub badges. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3374 +/- ##
========================================
Coverage 11.06% 11.06%
========================================
Files 99 99
Lines 17237 17237
Branches 8035 8035
========================================
Hits 1908 1908
- Misses 12643 12784 +141
+ Partials 2686 2545 -141
Flags with carried forward coverage won't be shown. Click here to find out more. |




Description
shields.io now supports Winget directly as of badges/shields#10245 🥳
Screenshot
https://img.shields.io/winget/v/LizardByte.Sunshine?style=for-the-badge&logo=data:image/png

Issues Fixed or Closed
Type of Change
.github/...)Checklist