Skip to content

Conversation

@ReenigneArcher
Copy link
Member

Description

Remove "recommended" from build dependencies, because this makes it an automatically installed runtime dependency. This is unnecessary and will increase bottle size for homebrew packages.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.43%. Comparing base (aca5d23) to head (22a0d00).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4612      +/-   ##
==========================================
- Coverage   15.46%   15.43%   -0.03%     
==========================================
  Files          94       94              
  Lines       19058    19060       +2     
  Branches     8775     8724      -51     
==========================================
- Hits         2947     2942       -5     
- Misses      12772    14856    +2084     
+ Partials     3339     1262    -2077     
Flag Coverage Δ
Archlinux ?
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.78% <ø> (+<0.01%) ⬆️
Homebrew-ubuntu-22.04 13.81% <ø> (+0.52%) ⬆️
Linux-AppImage 11.84% <ø> (ø)
Windows-AMD64 13.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 48 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 517be36 into master Jan 22, 2026
80 of 88 checks passed
@ReenigneArcher ReenigneArcher deleted the build/homebrew/optimize-build-options branch January 22, 2026 13:31
@codecov
Copy link

codecov bot commented Jan 22, 2026

Bundle Report

Changes will increase total bundle size by 5 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 968.59kB 5 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/config-*.js 5 bytes 60.83kB 0.01%
assets/Checkbox-*.js 5 bytes 2.11kB 0.24%
assets/ResourceCard-*.js -5 bytes 1.72kB -0.29%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants