Skip to content

Comments

fix(linux/kmsgrab): fix handle leak in update_cursor#4757

Merged
ReenigneArcher merged 1 commit intoLizardByte:masterfrom
psyke83:kms_cursor_handles
Feb 22, 2026
Merged

fix(linux/kmsgrab): fix handle leak in update_cursor#4757
ReenigneArcher merged 1 commit intoLizardByte:masterfrom
psyke83:kms_cursor_handles

Conversation

@psyke83
Copy link
Contributor

@psyke83 psyke83 commented Feb 21, 2026

Description

Fixes vram memory leak during cursor movement.

Screenshot

Issues Fixed or Closed

Fixes: #4703
Fixes: #3072

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@psyke83 psyke83 marked this pull request as ready for review February 21, 2026 19:20
@psyke83 psyke83 mentioned this pull request Feb 21, 2026
2 tasks
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@95da4b5). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/kmsgrab.cpp 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4757   +/-   ##
=========================================
  Coverage          ?   15.36%           
=========================================
  Files             ?       97           
  Lines             ?    20668           
  Branches          ?     9472           
=========================================
  Hits              ?     3176           
  Misses            ?    12930           
  Partials          ?     4562           
Flag Coverage Δ
Archlinux 11.06% <0.00%> (?)
FreeBSD-14.3-amd64 13.05% <ø> (?)
Homebrew-ubuntu-22.04 13.27% <0.00%> (?)
Linux-AppImage 11.47% <0.00%> (?)
Windows-AMD64 13.49% <ø> (?)
Windows-ARM64 12.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/kmsgrab.cpp 3.79% <0.00%> (ø)

@codecov
Copy link

codecov bot commented Feb 22, 2026

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher merged commit 502be64 into LizardByte:master Feb 22, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vram "leak" Memory leak using KMS capture

2 participants