Skip to content

fix: struct ordering broken in 188f1e2959e44b4a463bf4dee616a5cbee6f3557#4802

Merged
ReenigneArcher merged 1 commit intomasterfrom
fix/struct-ordering
Mar 2, 2026
Merged

fix: struct ordering broken in 188f1e2959e44b4a463bf4dee616a5cbee6f3557#4802
ReenigneArcher merged 1 commit intomasterfrom
fix/struct-ordering

Conversation

@ReenigneArcher
Copy link
Member

Description

Ordering of structs was inadvertently changed in 188f1e2. This PR partially reverts #4795.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link

codecov bot commented Mar 2, 2026

Bundle Report

Bundle size has no change ✅

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 15.33%. Comparing base (d157bb1) to head (d482b0d).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/windows/display.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4802      +/-   ##
==========================================
- Coverage   15.36%   15.33%   -0.04%     
==========================================
  Files          97       97              
  Lines       20647    20647              
  Branches     9453     9453              
==========================================
- Hits         3173     3166       -7     
- Misses      12918    15520    +2602     
+ Partials     4556     1961    -2595     
Flag Coverage Δ
Archlinux 11.07% <ø> (ø)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.07% <ø> (+<0.01%) ⬆️
Homebrew-ubuntu-22.04 13.27% <ø> (+<0.01%) ⬆️
Linux-AppImage 11.48% <ø> (+<0.01%) ⬆️
Windows-AMD64 13.43% <ø> (ø)
Windows-ARM64 12.35% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/input.h 0.00% <ø> (ø)
src/platform/common.h 29.52% <ø> (ø)
src/platform/linux/cuda.h 0.00% <ø> (ø)
src/platform/linux/graphics.h 0.00% <ø> (ø)
src/platform/linux/kmsgrab.cpp 3.79% <ø> (ø)
src/platform/linux/vaapi.cpp 2.83% <ø> (ø)
src/video_colorspace.cpp 24.44% <ø> (ø)
src/platform/windows/display.h 33.33% <0.00%> (ø)

... and 62 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 5f8dab0 into master Mar 2, 2026
67 of 68 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/struct-ordering branch March 2, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit 188f1e2 (pr #4795) causes the screen resolution to be wrong

1 participant