fix(linux): use FQDN service name in desktop launcher#4874
fix(linux): use FQDN service name in desktop launcher#4874ReenigneArcher merged 1 commit intoLizardByte:masterfrom
Conversation
|
Thank you for the PR submission, but I noticed you didn't use our PR template. Please update the PR to use the correct template. You can find it at https://github.com/LizardByte/.github/blob/master/.github/pull_request_template.md?plain=1 |
|
Aside from the template, this looks good. I missed this spot to change the service name. |
|
@ReenigneArcher Done — I've updated the PR description with the official template. Thanks for pointing it out! |
The .desktop file runs `systemctl start --u sunshine`, which relies on the `sunshine.service` alias. This alias only exists after the user runs `systemctl --user enable`, but the desktop launcher is intended to work without prior enable. Since commit daa99db renamed the service to `app-@PROJECT_FQDN@`, the desktop launcher should use the full service name directly so it works regardless of whether the service has been enabled.
ReenigneArcher
force-pushed
the
fix/desktop-service-name
branch
from
621b523 to
c0faab9
Compare
Bundle ReportBundle size has no change ✅ |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4874 +/- ##
==========================================
+ Coverage 17.91% 17.92% +0.01%
==========================================
Files 106 106
Lines 21980 21980
Branches 9812 9812
==========================================
+ Hits 3937 3940 +3
- Misses 15825 16000 +175
+ Partials 2218 2040 -178
Flags with carried forward coverage won't be shown. Click here to find out more. |
3 participants
Description
The
.desktoplauncher usessystemctl start --u sunshineto start the Sunshine service. However,sunshineis only an alias defined viaAlias=sunshine.servicein the unit file — this alias is only created when the service is enabled (systemctl enable).If the user has not enabled the service (e.g. they prefer to start it manually from the desktop launcher), the command silently fails because the
sunshine.servicesymlink does not exist.This PR replaces
sunshinewith the fully-qualified service nameapp-@PROJECT_FQDN@so the launcher works regardless of whether the service has been enabled.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage