fix: clear tray icon when unpairing the last paired client#4890
Conversation
|
Thank you for the PR submission, but I noticed you didn't use our PR template. Please update the PR to use the correct template. You can find it at https://github.com/LizardByte/.github/blob/master/.github/pull_request_template.md?plain=1 |
|
@ReenigneArcher I updated my submission |
Fixes LizardByte#4801 When unpairing the only remaining paired device, the tray icon stayed stuck on 'Game Session Paused' instead of returning to idle. This happened because single-client unpair removed the client record but did not terminate the running app/session state like 'unpair all' does. This change calls proc::proc.terminate() when the last paired client is removed, mirroring the existing cleanup behavior in the unpair-all path.
ReenigneArcher
force-pushed
the
fix-taskbar-icon-stuck-paused-4801
branch
from
c16c43b to
fca2b74
Compare
Bundle ReportBundle size has no change ✅ |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4890 +/- ##
==========================================
- Coverage 18.49% 18.47% -0.02%
==========================================
Files 107 107
Lines 22487 22490 +3
Branches 10004 10007 +3
==========================================
- Hits 4159 4156 -3
- Misses 15414 16865 +1451
+ Partials 2914 1469 -1445
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2 participants
Description
When unpairing the only remaining paired device via the Web UI, the Sunshine taskbar icon remains stuck on "Game Session Paused" instead of returning to the idle state.
The single-client unpair API (
POST /api/unpair) removes the paired client record but does not terminate the running app/session state. In contrast, the existingunpair allpath callsproc::proc.terminate()which clears the tray icon.This fix calls
proc::proc.terminate()when the last paired client is removed, mirroring the existing cleanup behavior in the unpair-all path.Screenshot
N/A - backend fix
Issues Fixed or Closed
Roadmap Issues
N/A
Type of Change
Checklist
AI Usage