fix(windows): update-path.bat registry command syntax in installer#4902
Merged
ReenigneArcher merged 2 commits intoLizardByte:masterfrom Mar 30, 2026
Merged
fix(windows): update-path.bat registry command syntax in installer#4902ReenigneArcher merged 2 commits intoLizardByte:masterfrom
ReenigneArcher merged 2 commits intoLizardByte:masterfrom
Conversation
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4902 +/- ##
==========================================
- Coverage 18.37% 18.34% -0.04%
==========================================
Files 107 107
Lines 22679 22679
Branches 10106 10106
==========================================
- Hits 4167 4160 -7
- Misses 16369 17062 +693
+ Partials 2143 1457 -686
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Move the /f option before the /d option to prevent the reg add command from ignoring the trailing /f option in Chinese-language environments. This issue only occurs with the remove command.
Add comments regarding registry command behavior on Chinese Windows systems.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Move the /f option before the /d option to prevent the reg add command from ignoring the trailing /f option in Chinese-language environments.
This issue only occurs with the remove command.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage