Skip to content

fix(windows): update-path.bat registry command syntax in installer#4902

Merged
ReenigneArcher merged 2 commits intoLizardByte:masterfrom
kmzs123:master
Mar 30, 2026
Merged

fix(windows): update-path.bat registry command syntax in installer#4902
ReenigneArcher merged 2 commits intoLizardByte:masterfrom
kmzs123:master

Conversation

@kmzs123
Copy link
Copy Markdown
Contributor

@kmzs123 kmzs123 commented Mar 24, 2026

Description

Move the /f option before the /d option to prevent the reg add command from ignoring the trailing /f option in Chinese-language environments.
This issue only occurs with the remove command.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@kmzs123 kmzs123 changed the title Fix registry command syntax in update-path.bat fix: registry command syntax in update-path.bat Mar 24, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Bundle Report

Bundle size has no change ✅

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.34%. Comparing base (d033346) to head (fc166f0).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4902      +/-   ##
==========================================
- Coverage   18.37%   18.34%   -0.04%     
==========================================
  Files         107      107              
  Lines       22679    22679              
  Branches    10106    10106              
==========================================
- Hits         4167     4160       -7     
- Misses      16369    17062     +693     
+ Partials     2143     1457     -686     
Flag Coverage Δ
Archlinux 12.16% <ø> (ø)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.99% <ø> (ø)
Homebrew-ubuntu-22.04 14.56% <ø> (ø)
Linux-AppImage 12.68% <ø> (ø)
Windows-AMD64 14.91% <ø> (ø)
Windows-ARM64 13.24% <ø> (+0.01%) ⬆️
macOS-arm64 19.01% <ø> (ø)
macOS-x86_64 18.38% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d033346...fc166f0. Read the comment docs.

kmzs123 added 2 commits March 30, 2026 08:51
Move the /f option before the /d option to prevent the reg add command from ignoring the trailing /f option in Chinese-language environments.
This issue only occurs with the remove command.
Add comments regarding registry command behavior on Chinese Windows systems.
@ReenigneArcher ReenigneArcher changed the title fix: registry command syntax in update-path.bat fix(windows): update-path.bat registry command syntax in installer Mar 30, 2026
@sonarqubecloud
Copy link
Copy Markdown

@ReenigneArcher ReenigneArcher merged commit 4ef856a into LizardByte:master Mar 30, 2026
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When updating or uninstalling Sunshine, it always unexpectedly deletes the website cookies saved in Chrome.

2 participants